Skip to content

Fix lint error coming up in main #10342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DaanHoogland merged 1 commit into from
Feb 7, 2025
Merged

Fix lint error coming up in main #10342

DaanHoogland merged 1 commit into from
Feb 7, 2025

Conversation

@sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Feb 7, 2025 •
edited
Loading

Description

This PR fixes Lint error reported by github action

" pre-commit run --all-files"

Screenshot from 2025-02-07 09-51-31

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr
shwstppr approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint GHA passing

@codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.02%. Comparing base (2ef1613) to head (4639ce9).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #10342      +/-   ##
============================================
- Coverage     16.02%   16.02%   -0.01%     
  Complexity    13146    13146              
============================================
  Files          5658     5658              
  Lines        496312   496312              
  Branches      60109    60109              
============================================
- Hits          79537    79531       -6     
- Misses       407926   407933       +7     
+ Partials       8849     8848       -1
Flag Coverage Δ
uitests 4.01% <ø> (ø)
unittests 16.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland DaanHoogland merged commit 648170c into apache:main Feb 7, 2025
25 checks passed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@sudo87 @dhslove
Fix lint error coming up in main (apache#10342)
d623eef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sudo87 @shwstppr @DaanHoogland